Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vite to beta #11979

Merged
merged 12 commits into from
Oct 4, 2024
Merged

Bump vite to beta #11979

merged 12 commits into from
Oct 4, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 12, 2024

Changes

Bump vite to beta. Also added pnpm.overrides to please the types issue with the vitest example

Testing

all should still pass. vite beta so far has no breaking change for astro.

Docs

Maybe at some point we should note in the migration guide that we bump Vite, when Vite becomes stable? (should be stable during the time we release stable too)

Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: 5a5e812

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Sep 12, 2024
@bluwy bluwy marked this pull request as draft September 12, 2024 17:19
@sarah11918
Copy link
Member

@bluwy I added a section for Vite to the upgrade guide https://5-0-0-beta.docs.astro.build/en/guides/upgrade-to/v5/#vite-60 -- you can update it as you like!

@bluwy bluwy marked this pull request as ready for review October 1, 2024 08:22
@github-actions github-actions bot added the semver: major Change triggers a `major` release label Oct 1, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bluwy !

@bluwy bluwy merged commit 423dfc1 into next Oct 4, 2024
14 checks passed
@bluwy bluwy deleted the plt-2516-bump-vite-beta branch October 4, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) semver: major Change triggers a `major` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants